Add BatchPreload to decode slabs in parallel and cache (for branch without atree inlining) #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intended use for BatchPreload is to speedup migrations.
BatchPreload decodes slabs in parallel and stores decoded
slabs in cache for later retrieval. This is useful for
migration program when most or all slabs are expected to
be migrated.
│ before.txt │ after.txt │
│ sec/op │ sec/op vs base │
StorageRetrieve/10-12 36.23µ ± 3% 35.33µ ± 4% ~ (p=0.075 n=10)
StorageRetrieve/100-12 469.6µ ± 8% 124.3µ ± 0% -73.52% (p=0.000 n=10)
StorageRetrieve/1000-12 6.678m ± 7% 2.303m ± 20% -65.51% (p=0.000 n=10)
StorageRetrieve/10000-12 29.81m ± 2% 12.26m ± 5% -58.86% (p=0.000 n=10)
StorageRetrieve/100000-12 303.33m ± 1% 88.40m ± 1% -70.86% (p=0.000 n=10)
StorageRetrieve/1000000-12 3.442 ± 1% 1.137 ± 3% -66.96% (p=0.000 n=10)
geomean 12.34m 4.816m -60.98%
│ before.txt │ after.txt │
│ B/op │ B/op vs base │
StorageRetrieve/10-12 21.59Ki ± 0% 21.59Ki ± 0% ~ (p=1.000 n=10)
StorageRetrieve/100-12 219.8Ki ± 0% 224.7Ki ± 0% +2.24% (p=0.000 n=10)
StorageRetrieve/1000-12 2.266Mi ± 0% 2.272Mi ± 0% +0.27% (p=0.000 n=10)
StorageRetrieve/10000-12 21.94Mi ± 0% 22.14Mi ± 0% +0.91% (p=0.000 n=10)
StorageRetrieve/100000-12 215.3Mi ± 0% 218.5Mi ± 0% +1.50% (p=0.000 n=10)
StorageRetrieve/1000000-12 2.211Gi ± 0% 2.212Gi ± 0% +0.05% (p=0.000 n=10)
geomean 6.919Mi 6.976Mi +0.82%
│ before.txt │ after.txt │
│ allocs/op │ allocs/op vs base │
StorageRetrieve/10-12 76.00 ± 0% 76.00 ± 0% ~ (p=1.000 n=10) ¹
StorageRetrieve/100-12 745.0 ± 0% 759.0 ± 0% +1.88% (p=0.000 n=10)
StorageRetrieve/1000-12 7.161k ± 0% 7.153k ± 0% -0.11% (p=0.000 n=10)
StorageRetrieve/10000-12 70.77k ± 0% 70.58k ± 0% -0.27% (p=0.000 n=10)
StorageRetrieve/100000-12 711.9k ± 0% 709.7k ± 0% -0.31% (p=0.000 n=10)
StorageRetrieve/1000000-12 7.115M ± 0% 7.077M ± 0% -0.54% (p=0.000 n=10)
geomean 22.93k 22.95k +0.11%
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fxamacker/add-nondeterministic-fast-commit-without-inlining #407 +/- ##
==============================================================================================
Coverage ? 66.81%
==============================================================================================
Files ? 14
Lines ? 8707
Branches ? 0
==============================================================================================
Hits ? 5818
Misses ? 2186
Partials ? 703 ☔ View full report in Codecov by Sentry. |
fxamacker
changed the base branch from
fxamacker/add-nondeterministic-fast-commit-without-inlining
to
feature/stable-cadence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #404 to
feature/stable-cadence branch.mainbranchFiles changedin the Github PR explorer