Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to check if address has unsaved changes in storage #450

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add function to check if address has unsaved changes in storage #450

merged 1 commit into from
Oct 25, 2024

Conversation

fxamacker
Copy link
Member

This PR adds the new function HasUnsavedChanges to indicate if there are any modified and unsaved slabs in storage for a given address.

func (s *PersistentSlabStorage) HasUnsavedChanges(address Address) bool

Updates Cadence issue onflow/cadence#3584

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker added the enhancement New feature or request label Oct 25, 2024
@fxamacker fxamacker self-assigned this Oct 25, 2024
turbolent
turbolent approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fxamacker fxamacker merged commit 5941314 into main Oct 25, 2024
8 checks passed
@fxamacker fxamacker mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@ramtinms ramtinms Awaiting requested review from ramtinms

Assignees

@fxamacker fxamacker

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent