Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of variable names in array tests #516

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Improve consistency of variable names in array tests #516

merged 1 commit into from
Feb 25, 2025

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Feb 25, 2025 •
edited
Loading

Updates #464

This PR renames values to expectedValues, etc.

NOTE: This PR does not affect non-test code.

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker self-assigned this Feb 25, 2025
@fxamacker fxamacker requested a review from turbolent as a code owner February 25, 2025 00:04
@fxamacker fxamacker changed the base branch from fxamacker/refactor-for-loops-in-array-tests to main February 25, 2025 19:25
@fxamacker fxamacker merged commit a91f8c2 into main Feb 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@fxamacker fxamacker

Labels
Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent