Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first ERC721 version + Solidity test suite #10

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Oct 30, 2024

Stacked on: #9

Closes: #2 #3
Related: #6

Description

  • Introduces the base ERC721 (minus random minting as TODO), accepting any IERC20 implementation as payment for minting
  • Adds the canonical WFLOW contract as a local dependency
  • Adds an example ERC20 for testing purposes

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review October 30, 2024 23:33
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but might be good to get someone who is more of a solidity expert to look at this

Base automatically changed from gio/reorg-repo to main October 31, 2024 19:19
@sisyphusSmiling sisyphusSmiling merged commit 07c2e0c into main Oct 31, 2024
2 of 3 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-base-erc721 branch October 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create ERC721 base contract
2 participants