-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LS] Bump onflow/cadence
dependency to v0.42.0
#220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the dependency versions 🙏
However, we might need to update Cadence version for all other dependencies of LS (i.e: transitive dependencies). For e.g: LS depends on flowkit, lint, flow-go-sdk, etc, which again depends on an older version of Cadence. Having two versions of Cadence in the dependency tree could cause some unexpected behaviors for some of these modules. i.e: They could pick the newer version of Cadence for which that module is not tested yet.
(Unfortunately, that's a problem with Go dependency resolution)
That's a good point 👍 Update: Also opened onflow/flow-go-sdk#488 |
d39fd24
to
a8edd7c
Compare
I have updated |
Depends on: #210
Description
Also adds a default implementation for the
ContractUpdateRecorded
method.master
branchFiles changed
in the Github PR explorer