Replace domain string with enum for AccountStorageMap key #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces domain string, such as "storage", "public", "private", etc. with domain enum (integer) as the key for AccountStorageMap. Also, this uses CBOR to store the domain integer in shortest form. This optimization further improves storage efficiency of domain payloads of PR 3664.
fxamacker
changed the base branch from
fxamacker/sync-feature-branch-combine-domain-payloads
to
feature/combine-domain-payloads-and-domain-storage-maps
This commit renames function convertKeyToDomain to convertAccountStorageMapKeyToStorageDomain.
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/combine-domain-payloads-and-domain-storage-maps commit cc95223 Collapsed results for better readability
|
fxamacker
merged commit 0abfa9a
into
feature/combine-domain-payloads-and-domain-storage-maps
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3584
Requires #3673
Description
This optimization further improves storage efficiency of domain payloads of PR #3664.
Thanks @turbolent 👍 for suggesting this optimization during PR review!
This PR replaces domain string, such as "storage", "public", "private", etc. with domain enum (integer) as the key for
AccountStorageMap.Also, this uses CBOR to store the domain integer in shortest form.
masterbranchFiles changedin the Github PR explorer