Skip to content

Test interface function with conditions#3889

Merged
turbolent merged 3 commits intomasterfrom
bastian/test-interface-conditions
Apr 23, 2025
Merged

Test interface function with conditions#3889
turbolent merged 3 commits intomasterfrom
bastian/test-interface-conditions

Conversation

@turbolent
Copy link
Copy Markdown
Member

@turbolent turbolent commented Apr 21, 2025

Description

Add some more for interface functions with conditions to check how/that they behave correctly.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Apr 21, 2025
@turbolent turbolent requested a review from SupunS as a code owner April 21, 2025 22:58
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2025

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 5be5ca4
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link
Copy Markdown
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these test!

(and sorry for the delayed review; I thought I already approved it 🙇 )

@turbolent
Copy link
Copy Markdown
Member Author

No worries at all!

@turbolent turbolent merged commit e026696 into master Apr 23, 2025
10 of 12 checks passed
@turbolent turbolent deleted the bastian/test-interface-conditions branch April 23, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants