PKG -- [FCL-WC] Add notifications for pending WC/RPC requests #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 75e24f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
force-pushed
the
jribbink/wc-modal
branch
from
0fdad14
to
7698bf6
Compare
jribbink
changed the title
jribbink
changed the title
jribbink
force-pushed
the
jribbink/wc-modal
branch
from
fa75993
to
4df5ac8
Compare
|
It might be nice if the wallet can turn the notifications off if they have their own push notification system they want to use instead. |
|
Yeah agree.
Agree. Will add. |
|
Added it to the |
chasefleming
approved these changes
Nov 20, 2024
This was referenced Nov 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1969
Closes #1979
This PR adds notifications indicating that there is a pending request on the user's mobile wallet. On mobile, clicking on the notification will open the deeplink to the user's wallet.
Decision to use
preact(lightweight ~4kb React implementation) and tailwind was based on maintaining consistency throughout Flow's projects and anticipating future scope (react/react-domis just too heavy to justify here). It's definitely overkill and this could have been written with vanilla JavaScript or a lightweight templating engine likelit-html. It would be very trivial to swap this out for an alternative, so please leave feedback if there are any concerns here.Mobile Light Mode:
Mobile Dark Mode:
Desktop Light Mode:
Desktop Dark Mode:
