Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix the init Counter transaction #1818

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

chasefleming
Copy link
Member

@chasefleming chasefleming commented Nov 5, 2024

Closes #1817

Description

  • Use a tx without a storage tx required
  • Add more to readme

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@chasefleming chasefleming added the Bug The issue represents a bug, malfunction, regression label Nov 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.47%. Comparing base (921e9bd) to head (c6a2839).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1818   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          95       95           
  Lines        6490     6490           
=======================================
  Hits         1848     1848           
  Misses       4462     4462           
  Partials      180      180           
Flag Coverage Δ
unittests 28.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming chasefleming merged commit 3e0a1f6 into master Nov 5, 2024
8 checks passed
@chasefleming chasefleming deleted the cf/fix-init-tx branch November 5, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue represents a bug, malfunction, regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction from init does not work
4 participants