Skip to content

Conversation

@chasefleming
Copy link
Member

@chasefleming chasefleming commented Jan 7, 2026

Description

Adds a security warning when running CLI commands if accounts have inline keys stored directly in flow.json.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@chasefleming chasefleming added the Improvement Technical work without new features, refactoring, improving tests label Jan 7, 2026
@chasefleming chasefleming changed the title Add security warning for accounts with inline private keys Add security warning for accounts with inline keys Jan 7, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/command/command.go 0.00% 19 Missing ⚠️

📢 Thoughts on this report? Let us know!

@chasefleming chasefleming merged commit f6a29c3 into master Jan 7, 2026
11 checks passed
@chasefleming chasefleming deleted the cf/extract-warning branch January 7, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants