Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new script that checks if payer has balance to pay for tx #435

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Add a new script that checks if payer has balance to pay for tx #435

merged 9 commits into from
Jul 8, 2024

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Jun 10, 2024 •
edited
Loading

This is a part of onflow/flow-go#6004

@illia-malachyn
Copy link
Contributor Author

BTW, I noticed that Should be able to change the conversion and minimum fails when I run only my test

@illia-malachyn
Copy link
Contributor Author

@janezpodhostnik Can u take a look at it?

peterargue
peterargue reviewed Jun 10, 2024
View reviewed changes
lib/go/templates/service_templates.go Outdated Show resolved Hide resolved
lib/go/test/service_test.go Outdated Show resolved Hide resolved
lib/go/test/service_test.go Outdated Show resolved Hide resolved
transactions/FlowServiceAccount/scripts/check_if_payer_has_sufficient_balance.cdc Outdated Show resolved Hide resolved
@illia-malachyn illia-malachyn mentioned this pull request Jun 11, 2024
Merged
janezpodhostnik
janezpodhostnik approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

joshuahannan
joshuahannan approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this! Great work. :)

@joshuahannan
Copy link
Member

Also, I'm merging the stable-cadence branch today, so after I do that, you'll need to pull the latest code from master, update everything here to use Cadence 1.0, and then I can review again

@joshuahannan
Copy link
Member

@illia-malachyn Thank you for adding this! Is this PR ready to be merged?

@illia-malachyn
Copy link
Contributor Author

@joshuahannan Yes, you can merge it

@joshuahannan joshuahannan merged commit 83cacb3 into onflow:master Jul 8, 2024
1 check passed
@jordanschalm jordanschalm mentioned this pull request Jul 25, 2024
Merged
jordanschalm added a commit that referenced this pull request Jul 25, 2024
@jordanschalm @chasefleming @illia-malachyn
Sync feature/efm-recovery with master (#437)
be37706 
* Remove feature branch

* Add a new script that checks if payer has balance to pay for tx (#435)

* Add a new script that checks if payer has balance to pay for tx

* Rewrite check_if_payer_has_sufficient_balance to return struct

* Update contract to cadence 1

* create custom minted account

* payer executes tx and pays for it

* fix tx signers

* refactor test

---------

Co-authored-by: Chase Fleming <[email protected]>
Co-authored-by: Illia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@joshuahannan joshuahannan joshuahannan approved these changes

@peterargue peterargue Awaiting requested review from peterargue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illia-malachyn @joshuahannan @janezpodhostnik @peterargue