Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK adapter doesn't implement BlockPayload retrieval #703

Closed
bartolomej opened this issue Jul 7, 2024 · 0 comments · Fixed by #704
Closed

SDK adapter doesn't implement BlockPayload retrieval #703

bartolomej opened this issue Jul 7, 2024 · 0 comments · Fixed by #704
Assignees
Labels

Comments

@bartolomej
Copy link
Contributor

Problem

Functions for retrieving full block information (GetBlockById, GetBlockByHeight, GetLatestBlock) don't implement conversion from flowgo.Payload to sdk.BlockPayload, but instead just return an empty sdk.BlockPayload struct.

See example: https://github.com/onflow/flow-emulator/blame/799f57c037f3bd33acdd4e57a4d1b55ee58fc5d9/adapters/sdk.go#L179-L186

Steps to Reproduce

Use SDK adapter and try retrieving block payload (e.g. collection guarantees).

Acceptance Criteria

SDK adapter should support retrieval of block payloads.

Context

I'm playing around with building a revamped web-based playground. This was proposed in the grant: onflow/developer-grants#260.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants