Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlockPayload conversion in SDK adapter #704

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Fix BlockPayload conversion in SDK adapter #704

merged 4 commits into from
Jul 9, 2024

Conversation

bartolomej
Copy link
Contributor

@bartolomej bartolomej commented Jul 7, 2024 •
edited
Loading

Closes: #703

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

turbolent
turbolent approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

adapters/sdk.go Outdated Show resolved Hide resolved
@turbolent
Copy link
Member

Could you please add a/some test(s)?

@bartolomej
Copy link
Contributor Author

Could you please add a/some test(s)?

Yep, good idea! I actually just forgot to update them as they were failing. Fixed in 55388e7

sideninja
sideninja approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, added a code style suggestion

@turbolent
Copy link
Member

@bartolomej Thank you for adding the tests! 👍

@turbolent turbolent enabled auto-merge July 9, 2024 04:13
@turbolent turbolent merged commit 6a67c01 into onflow:master Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@sideninja sideninja sideninja approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK adapter doesn't implement BlockPayload retrieval
3 participants
@bartolomej @turbolent @sideninja