Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back comment for variable transaction fees #457

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Bring back comment for variable transaction fees #457

merged 1 commit into from
Aug 1, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Aug 1, 2023

Description

Some comments were accidentally removed in #451, this PR brings them back 😇

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@m-Peter
Copy link
Contributor Author

m-Peter commented Aug 1, 2023

cc @turbolent

turbolent
turbolent approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@turbolent turbolent added the Documentation The issue in documentation, missing docs, invalid docs, outdated docs label Aug 1, 2023
@turbolent turbolent merged commit d770012 into onflow:master Aug 1, 2023
3 checks passed
@m-Peter m-Peter deleted the add-comment-for-transaction-fees branch September 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@sideninja sideninja Awaiting requested review from sideninja

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

Assignees
No one assigned
Labels
Documentation The issue in documentation, missing docs, invalid docs, outdated docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-Peter @turbolent