Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest metrics instantiation - auto update to onflow/cadence v0.40.0 #462

Conversation

peterargue
Copy link
Contributor

@peterargue peterargue commented Aug 8, 2023

Description

Fixes issues with rest metrics initialization discovered by #461


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@peterargue peterargue changed the base branch from master to auto-update-onflow-cadence-v0.40.0 August 8, 2023 21:36
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (auto-update-onflow-cadence-v0.40.0@02a44bf). Click here to learn what that means.
The diff coverage is n/a.

@@                          Coverage Diff                          @@
##             auto-update-onflow-cadence-v0.40.0     #462   +/-   ##
=====================================================================
  Coverage                                      ?   54.85%           
=====================================================================
  Files                                         ?       28           
  Lines                                         ?     3617           
  Branches                                      ?        0           
=====================================================================
  Hits                                          ?     1984           
  Misses                                        ?     1473           
  Partials                                      ?      160           
Flag Coverage Δ
unittests 54.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Aug 8, 2023
@turbolent turbolent merged commit db6cfd9 into auto-update-onflow-cadence-v0.40.0 Aug 8, 2023
3 checks passed
@turbolent turbolent deleted the petera/auto-update-onflow-cadence-v0.40.0-rest-metrics-fix branch August 8, 2023 21:41
@turbolent
Copy link
Member

Great! Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants