Allow configuration of blockchain's interpreter runtime #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Peter
requested review from
sideninja,
turbolent,
janezpodhostnik and
bluesign
as code owners
6 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 55.00% 55.03% +0.03%
==========================================
Files 28 28
Lines 3620 3632 +12
==========================================
+ Hits 1991 1999 +8
- Misses 1470 1474 +4
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
turbolent
added
the
Improvement
|
I also came across a bug, which I have fixed here: cd45777 |
m-Peter
force-pushed
the
configurable-blockchain-runtime-environment
branch
from
cd45777
to
5566481
Compare
turbolent
approved these changes
Sep 21, 2023
|
Is the injection via |
…ader We also rename Blockchain's newFVMContextFromHeader() to setFVMContextFromHeader()
We also update Blockchain.GetSourceFile() to use the Blockchain.NewScriptEnvironment() method.
m-Peter
force-pushed
the
configurable-blockchain-runtime-environment
branch
from
e15a79d
to
3be569a
Compare
|
@janezpodhostnik Very good point 👏 |
janezpodhostnik
approved these changes
Sep 27, 2023
SupunS
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards: onflow/cadence-tools#210
Description
Also expose a public method for creating script environments based on blockchain's ledger state.
These utility functions facilitate the usage of emulator's blockchain, as a library for 3rd party tools (e.g.
cadence-tools/test).For contributor use:
masterbranchFiles changedin the GitHub PR explorer