Add support for EVM.heartbeat resource on system chunk transaction
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Peter
requested review from
sideninja,
turbolent,
janezpodhostnik,
bluesign,
chasefleming and
jribbink
as code owners
|
@turbolent can you check why the migration test breaks, Ardit disabled it for the sake of referencing this update flow-emulator in EVM GW but we should resolve the issue. I tried recreating a new snapshot for the migration test which has the EVM heartbeat updated contract, but still no luck, I'm not sure which version I should use when generating the snapshot so I used v0.62.1 which I'm not sure if correct. Can you help with this |
sideninja
added a commit
that referenced
this pull request
Jul 23, 2024
the pre-1.0 Emulator state does not contain the EVM contract, so deploy it. This must be done by deploying the minimal contract and updating to the full contract, as deploying the full contract is only possible during bootstrapping
|
I improved the EVM migration in flow-go:
Once those PRs are merged, we should bump the flow-go version and then this PR should pass. Testing it locally using a temporary replace worked. |
turbolent
added
the
Improvement
turbolent
approved these changes
Jul 24, 2024
This was referenced Jul 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #719
Description
The emission of
EVM.BlockExecutedevents is now part of the system chunk transaction.In order for tools using the Flow Emulator, to function properly, we need to handle this in Emulator's system chunk transaction as well.
Furthermore, since this system chunk transaction is rather special, we need to make its event/s available to APIs such as the event streaming.
For contributor use:
masterbranchFiles changedin the GitHub PR explorer