Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cross-VM NFTs into NFT to EVM path #179

Open
wants to merge 28 commits into
base: flip-318
Choose a base branch
from

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Mar 28, 2025

Closes: #149
Stacked on: #176

Description

  • Integrates custom associations into the bridgeNFTToEVM route, breaking down into sub-handler methods depending on the case
  • Test cases covering net new EVM-native & Cadence-native as well as previously onboarded Cadence-native NFTs
  • Adds an event to NFTFulfillmentMinter interface to identify when custom cross-VM NFTs are moved into Cadence from EVM
  • Minor fixes to ExampleCadenceNativeNFT.cdc

For contributor use:

  • Targeted PR against flip-318 branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (flip-318@090b055). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cadence/contracts/bridge/FlowEVMBridge.cdc 53.84% 18 Missing ⚠️
cadence/contracts/bridge/FlowEVMBridgeConfig.cdc 42.85% 4 Missing ⚠️
cadence/contracts/bridge/FlowEVMBridgeUtils.cdc 66.66% 2 Missing ⚠️
...cts/bridge/FlowEVMBridgeCustomAssociationTypes.cdc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             flip-318     #179   +/-   ##
===========================================
  Coverage            ?   81.07%           
===========================================
  Files               ?       23           
  Lines               ?     1395           
  Branches            ?        0           
===========================================
  Hits                ?     1131           
  Misses              ?      264           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from gio/update-pause-routes to flip-318 March 29, 2025 21:02
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review April 1, 2025 18:13
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner April 1, 2025 18:13
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! No comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants