-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Merge pull request #759 from onflow/mpeter/consolidate-tx-max-gas-limit" #769
Conversation
WalkthroughThe changes standardize gas limit references and error handling across the codebase. In the API endpoints, error returns are now processed via a centralized Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant R as Requester/SendRawTransaction
C->>R: Send Raw Transaction Request
alt Gas limit too high
R-->>C: Return error "transaction gas limit is too high"
else Within allowed gas limit
R->>R: Process transaction using EstimateGas (BlockGasLimit)
R-->>C: Return transaction result
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (13)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
This reverts commit 7274b59, reversing changes made to da6552b.
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Refactor
Tests