Port #5755 to feature/atree-inlining-cadence-v0.42 #5765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds --fix-testnet-slabs-with-broken-references flag to the migration program. It uses a feature from onflow/atree#388 to fix 10 testnet registers affecting 9 testnet accounts. The 9 testnet accounts are hardcoded in this commit to prevent accidentally applying this fix to any other accounts. In testnet, broken references seem to have resulted from a bug that was fixed 2 years ago by onflow/cadence#1565. A broken reference is a `StorageID` referencing a non-existent register. So far, only 10 registers in testnet (none on mainnet) were found to contain broken references.
There are 9 testnet accounts with known issues that will be fixed during migration, so we don't need to skip them. The fixes during migration will only applied to 9 hardcoded testnet accounts for the identified problem.
|
@fxamacker Integrated the migration in f9798b7 |
fxamacker
reviewed
Apr 23, 2024
cmd/util/cmd/execution-state-extract/execution_state_extract.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Faye Amacker <[email protected]>
fxamacker
approved these changes
Apr 23, 2024
turbolent
changed the title
|
@turbolent There are some compile errors due to breaking compatibility of atree. Do you mind if I push some commits to fix them? |
SupunS
approved these changes
Apr 23, 2024
This function was added in PR #5613 by Janez for feature/stable-cadence and was copied into PR #5765. Co-authored-by: Janez Podhostnik <[email protected]>
|
6f7004c and e5c6ec2 look great @fxamacker, thank you for fixing this up! |
…-5755-atree-inlining-cadence-v0.42
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/atree-inlining-cadence-v0.42 #5765 +/- ##
=====================================================================
Coverage 53.39% 53.39%
=====================================================================
Files 16 16
Lines 2270 2270
=====================================================================
Hits 1212 1212
Misses 971 971
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fxamacker
approved these changes
Apr 23, 2024
turbolent
merged commit 4836ac7
into
feature/atree-inlining-cadence-v0.42
55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards onflow/cadence#3220
Port #5755 to https://github.com/onflow/flow-go/tree/feature/atree-inlining-cadence-v0.42
Work done by @fxamacker
This PR adds
--fix-testnet-slabs-with-broken-referencesflag to the migration program.It uses a feature from onflow/atree#388 to fix 10 testnet registers affecting 9 testnet accounts.
The 9 testnet accounts are hardcoded in this commit to prevent accidentally applying this fix to any other accounts.
In testnet, broken references seem to have resulted from a bug that was fixed 2 years ago by onflow/cadence#1565.
A broken reference is a
StorageIDreferencing a non-existent register. So far, only 10 registers in testnet (none on mainnet) were found to contain broken references.