-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Created new gRPC methods for GetAccountBalance and GetAccountKeys. #6144
[Access] Created new gRPC methods for GetAccountBalance and GetAccountKeys. #6144
Conversation
…pc-methods-GetAccountBalance-GetAccountKeys
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6144 +/- ##
==========================================
- Coverage 41.58% 41.39% -0.19%
==========================================
Files 1976 1976
Lines 139757 140591 +834
==========================================
+ Hits 58112 58201 +89
- Misses 75609 76335 +726
- Partials 6036 6055 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this is looking good. added a couple comments related to my comments in the proto changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replied to your question about getting the available balance when using execution-only-mode. sorry for the churn on that request.
…pc-methods-GetAccountBalance-GetAccountKeys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few more comments. after this I think it's ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @Guitarheroua can you take a look as well. after we get the merged emulator commit added, I'll approve and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor comment about documentation.
@AndriiDiachuk I merged the emulator PR, please update this PR with the commit and I'll approve and merge |
Made the changes, but please check if I made any mistakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR new gRPC methods
GetAccountBalance
andGetAccountKeys
were added.Closing issue: #5999
Related PRs: onflow/flow#1475 onflow/flow-emulator#707