-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review Version] Refactor Protocol State with Pebble-based Storage #6197
Closed
zhangchiqing
wants to merge
38
commits into
leo/v0.33-pebble-base
from
leo/v0.33-pebble-storage-to-review
Closed
Changes from 13 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
5af77d0
refacotr protocol state with pebble-based storage
zhangchiqing 28f96be
fix iteration
zhangchiqing e98b073
update utils with pebble
zhangchiqing f724039
rename to read pebble
zhangchiqing a7d08c5
refactor iterator
zhangchiqing 2bd8329
add comment
zhangchiqing 9182dbf
add delete range operation to batch writer
zhangchiqing 05e758d
update git ignore
zhangchiqing 5af2b0c
fix util
zhangchiqing dd6c183
remove truncate
zhangchiqing 2efb925
preventing dirty reads when storing qcs
zhangchiqing e2ecc2c
small refactor
zhangchiqing b777c5e
update mocks
zhangchiqing c3cd924
removing some outdated comments and whitespaces
51969ec
Merge branch 'leo/v0.33-pebble-base' into alex/v0.33-pebble-storage-t…
b277372
refactor iterate
zhangchiqing d5d8b21
refactor using keyUpperBound
zhangchiqing 80f1a2f
making indexing own receipts concurrent safe
zhangchiqing 26865bb
address review comments
zhangchiqing aad84b1
Apply suggestions from code review
zhangchiqing c2ad1e9
address review comments
zhangchiqing d2c1016
refactor getStartEndKeys with prefixUpperBound
zhangchiqing 789d2bb
refactor indexing new block
zhangchiqing 148c877
refactor new follower state
zhangchiqing 2ea5698
add test case to events
zhangchiqing 77b64c0
not releasing the lock until the pebblw batch update is committed
zhangchiqing c904ec4
fix concurrency
zhangchiqing 95043aa
making finalization concurrency safe
zhangchiqing f9436d8
adding test cases
zhangchiqing afd8526
add concurrency safety tests
zhangchiqing 9737a92
making it concurrent-safe for indexing approval
zhangchiqing a01d317
update test cases for Index
zhangchiqing 8eb0f74
Merge pull request #6374 from onflow/leo/v0.33-pebble-storage-index-a…
zhangchiqing 29d78d8
Merge pull request #6373 from onflow/leo/v0.33-pebble-storage-finalizing
zhangchiqing ce2775e
Merge pull request #6360 from onflow/leo/v0.33-pebble-storage-block-i…
zhangchiqing d527912
Apply suggestions from code review
zhangchiqing 7fff0ee
Merge pull request #6354 from onflow/leo/v0.33-pebble-storage-my-rece…
zhangchiqing 38dd0c8
Merge pull request #6316 from onflow/leo/v0.33-pebble-storage-iterate
zhangchiqing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to use a flag for switching between pebble and badger. I had to make a copy of the finalizer, and use a different name for the pebble version of the finalizer.
Same for the collection finalizer