Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing System Contracts #6211

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add missing System Contracts #6211

merged 2 commits into from
Jul 15, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jul 12, 2024

Closes #6210
Closes #6142

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (b63957c) to head (73970f8).
Report is 25 commits behind head on master.

Files Patch % Lines
fvm/systemcontracts/system_contracts.go 57.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6211      +/-   ##
==========================================
- Coverage   41.58%   41.39%   -0.19%     
==========================================
  Files        1976     1976              
  Lines      139757   140601     +844     
==========================================
+ Hits        58112    58203      +91     
- Misses      75609    76338     +729     
- Partials     6036     6060      +24     
Flag Coverage Δ
unittests 41.39% <57.14%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent requested review from joshuahannan and a team July 12, 2024 18:51
@turbolent
Copy link
Member

@joshuahannan Does this look right?

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turbolent
Copy link
Member

For context: this is for onflow/flow-cli#1669

@joshuahannan
Copy link
Member

joshuahannan commented Jul 12, 2024

Looks good, but can you also add FungibleTokenMetadataViews and FungibleTokenSwitchboard? They aren't in there yet either. They are both deployed to the same account as FungibleToken. Thank you!

@jribbink jribbink changed the title Add Burner to System Contracts Add missing System Contracts Jul 12, 2024
@jribbink jribbink requested a review from turbolent July 12, 2024 19:32
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

@janezpodhostnik janezpodhostnik added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@janezpodhostnik janezpodhostnik added this pull request to the merge queue Jul 15, 2024
Merged via the queue into master with commit a9a235c Jul 15, 2024
55 checks passed
@janezpodhostnik janezpodhostnik deleted the jribbink/add-burner branch July 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Burner to System Contracts SystemContractsForChain missing some contracts
5 participants