Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meter method which returns remaining computation for given computation kind #6215

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent added the enhancement New feature or request label Jul 12, 2024
@turbolent turbolent requested review from a team July 12, 2024 22:04
@turbolent turbolent self-assigned this Jul 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Project coverage is 41.15%. Comparing base (6a254ed) to head (7415145).

Files with missing lines Patch % Lines
fvm/storage/state/execution_state.go 0.00% 9 Missing ⚠️
fvm/environment/mock/meter.go 0.00% 3 Missing ⚠️
fvm/meter/computation_meter.go 75.00% 2 Missing and 1 partial ⚠️
fvm/environment/meter.go 0.00% 2 Missing ⚠️
fvm/storage/state/transaction_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6215   +/-   ##
=======================================
  Coverage   41.14%   41.15%           
=======================================
  Files        2031     2031           
  Lines      179571   179596   +25     
=======================================
+ Hits        73886    73906   +20     
- Misses      99475    99479    +4     
- Partials     6210     6211    +1     
Flag Coverage Δ
unittests 41.15% <32.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Sep 14, 2024
@github-actions github-actions bot closed this Sep 21, 2024
@bluesign
Copy link
Contributor

Is this stale?

@janezpodhostnik
Copy link
Contributor

@bluesign ComputationAvailable was added in another PR https://github.com/onflow/flow-go/pull/4861/files#diff-f0abf60d6957bfe1c0f9a9c50108652f85d6515ca786892300f48b76e0144f86R100

@turbolent turbolent reopened this Oct 16, 2024
@turbolent turbolent force-pushed the bastian/computation-remaining branch from a3f26d7 to f075976 Compare October 16, 2024 22:38
@turbolent turbolent requested review from a team and janezpodhostnik October 16, 2024 22:39
@turbolent turbolent removed the Stale Label used when marking an issue stale. label Oct 16, 2024
@turbolent
Copy link
Member Author

@onflow/flow-cadence-execution PTAL

@turbolent turbolent added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit 8d5a3b3 Oct 24, 2024
55 checks passed
@turbolent turbolent deleted the bastian/computation-remaining branch October 24, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants