-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Mark execution data fulfilled after all consumers finish processing #6217
[Access] Mark execution data fulfilled after all consumers finish processing #6217
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6217 +/- ##
==========================================
+ Coverage 41.54% 41.55% +0.01%
==========================================
Files 1992 1993 +1
Lines 141553 141618 +65
==========================================
+ Hits 58804 58853 +49
- Misses 76625 76641 +16
Partials 6124 6124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
module/executiondatasync/execution_data/execution_data_producer.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing the race condition. added a few comments, but I think you're on the right track
module/executiondatasync/execution_data/execution_data_producer.go
Outdated
Show resolved
Hide resolved
module/executiondatasync/execution_data/execution_data_producer.go
Outdated
Show resolved
Hide resolved
module/executiondatasync/execution_data/execution_data_producer.go
Outdated
Show resolved
Hide resolved
module/executiondatasync/execution_data/execution_data_producer.go
Outdated
Show resolved
Hide resolved
integration/tests/access/cohort3/execution_data_pruning_test.go
Outdated
Show resolved
Hide resolved
…of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6138-execution-data-sync-improvements
integration/tests/access/cohort3/execution_data_pruning_test.go
Outdated
Show resolved
Hide resolved
integration/tests/access/cohort3/execution_data_pruning_test.go
Outdated
Show resolved
Hide resolved
…r GetEventsForHeightRange reguest in test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @UlyanaAndrukhiv! looks good.
Closes: #6138
Context
In this pull request:
Added supporting of handling 2 cases ( newly indexed blocks on the
indexer
and newly synced execution data ondownloader
) for marking a height as fulfilled for theExecution data pruner
.In the case where
indexing
is disabled, butexecution sync
and pruning are enabled - pruner registersDownload
asExecutionDataProducer
and marks a height as fulfilled as soon as the data for a block is stored.In the case where indexing and execution sync enabled - pruner checks the lower processed value.
Added integration test, updated existing functional tests for pruner