Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Added metrics for transaction validator #6239

Conversation

Guitarheroua
Copy link
Collaborator

@Guitarheroua Guitarheroua commented Jul 22, 2024

#6128

Introduced metrics implementation for transaction validator

DEPENDS ON onflow/flow-emulator#723

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 29.52381% with 74 lines in your changes missing coverage. Please review.

Project coverage is 41.44%. Comparing base (e3d9d29) to head (9012cd0).

Files with missing lines Patch % Lines
module/metrics/transaction_validation.go 0.00% 26 Missing ⚠️
access/validator.go 69.23% 11 Missing and 1 partial ⚠️
module/mock/transaction_validation_metrics.go 0.00% 11 Missing ⚠️
module/mock/access_metrics.go 0.00% 6 Missing ⚠️
module/mock/collection_metrics.go 0.00% 6 Missing ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 5 Missing ⚠️
module/metrics/access.go 0.00% 3 Missing ⚠️
module/metrics/noop.go 0.00% 3 Missing ⚠️
module/metrics/collection.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6239   +/-   ##
=======================================
  Coverage   41.44%   41.44%           
=======================================
  Files        2017     2019    +2     
  Lines      143802   143861   +59     
=======================================
+ Hits        59596    59621   +25     
- Misses      78028    78068   +40     
+ Partials     6178     6172    -6     
Flag Coverage Δ
unittests 41.44% <29.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

access/validator.go Outdated Show resolved Hide resolved
module/metrics/collection.go Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
access/validator.go Outdated Show resolved Hide resolved
access/validator.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
@Guitarheroua Guitarheroua marked this pull request as ready for review July 25, 2024 15:49
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple small comments, but otherwise this looks good

access/validator.go Outdated Show resolved Hide resolved
access/validator.go Outdated Show resolved Hide resolved
access/validator.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
module/metrics/transaction_validation.go Outdated Show resolved Hide resolved
access/validator.go Show resolved Hide resolved
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'll approve and merge after the emulator change is merged and the replace is removed from this PR

@peterargue
Copy link
Contributor

@Guitarheroua please fix conflicts

@Guitarheroua Guitarheroua self-assigned this Aug 29, 2024
@peterargue peterargue added this pull request to the merge queue Aug 29, 2024
Merged via the queue into onflow:master with commit 9708618 Aug 29, 2024
55 checks passed
@peterargue peterargue deleted the AndriiSlisarchuk/6128-metrics-for-tx-validator branch August 29, 2024 18:11
Guitarheroua pushed a commit to The-K-R-O-K/flow-go that referenced this pull request Oct 9, 2024
…-metrics-for-tx-validator

[Access] Added metrics for transaction validator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants