-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Added metrics for transaction validator #6239
[Access] Added metrics for transaction validator #6239
Conversation
…isarchuk/6128-metrics-for-tx-validator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6239 +/- ##
=======================================
Coverage 41.44% 41.44%
=======================================
Files 2017 2019 +2
Lines 143802 143861 +59
=======================================
+ Hits 59596 59621 +25
- Misses 78028 78068 +40
+ Partials 6178 6172 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…isarchuk/6128-metrics-for-tx-validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple small comments, but otherwise this looks good
…isarchuk/6128-metrics-for-tx-validator
…isarchuk/6128-metrics-for-tx-validator
Co-authored-by: Peter Argue <[email protected]>
…isarchuk/6128-metrics-for-tx-validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I'll approve and merge after the emulator change is merged and the replace is removed from this PR
…isarchuk/6128-metrics-for-tx-validator
@Guitarheroua please fix conflicts |
…-metrics-for-tx-validator [Access] Added metrics for transaction validator
#6128
Introduced metrics implementation for transaction validator
DEPENDS ON onflow/flow-emulator#723