-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Use Indexed height when checking payer balance #6292
[Access] Use Indexed height when checking payer balance #6292
Conversation
… which was used for checkinf payer balance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6292 +/- ##
==========================================
- Coverage 41.28% 41.27% -0.02%
==========================================
Files 2030 2030
Lines 145837 145865 +28
==========================================
- Hits 60213 60202 -11
- Misses 79397 79437 +40
+ Partials 6227 6226 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just has a couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a suggestion for phrasing one of the comments. otherwise this looks good
Co-authored-by: Peter Argue <[email protected]>
@AndriiDiachuk please fix conflicts |
@AndriiDiachuk looks like there's some more conflicts to fix. can you take a look |
…dexed-height-checking-payer-balance
…dexed-height-checking-payer-balance
…dexed-height-checking-payer-balance
…dexed-height-checking-payer-balance
…dexed-height-checking-payer-balance
…m:AndriiDiachuk/flow-go into use-indexed-height-checking-payer-balance
…checking-payer-balance [Access] Use Indexed height when checking payer balance
In this PR was changed block height for checking payer balance. Instead of using the latest sealed block, was used the latest indexed block.
Related PR: onflow/flow-emulator#724
Closes: #6129