-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Change SendAndSubscribe endpoint's MessageIndex to start at 0 #6598
[Access] Change SendAndSubscribe endpoint's MessageIndex to start at 0 #6598
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6598 +/- ##
=======================================
Coverage 41.20% 41.21%
=======================================
Files 2052 2052
Lines 182191 182197 +6
=======================================
+ Hits 75075 75088 +13
+ Misses 100824 100818 -6
+ Partials 6292 6291 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ex-start-with-zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also fixed the same issue for Accounts and Events. I know this is out of scope, but could you please also check MessageIndex for blocks to see if the implementation in all subscriptions is consistent?
Other than that, looks good to me.
…-send-and-subscribe-endoints-msg-index-start-with-zero
…-zero' of github.com:AndriiDiachuk/flow-go into change-send-and-subscribe-endoints-msg-index-start-with-zero
…ex-start-with-zero
…-send-and-subscribe-endoints-msg-index-start-with-zero
Closes: #6575
Related PR: onflow/flow#1520