Add verification tool for evm offchain replay #6755
Conversation
zhangchiqing
changed the base branch from
master
to
leo/add-testcase-for-offchain-evm-backward-compatibilities
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6755 +/- ##
==========================================
- Coverage 41.26% 41.11% -0.15%
==========================================
Files 2061 2067 +6
Lines 182702 183228 +526
==========================================
- Hits 75384 75336 -48
- Misses 101010 101582 +572
- Partials 6308 6310 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
103f257
to
d379a68
Compare
| return nil | ||
| } | ||
|
|
||
| func parseEVMEvents(evts flow.EventsList) (*events.BlockEventPayload, []events.TransactionEventPayload, error) { |
There was a problem hiding this comment.
This does not seem to handle the case where there was a period that did not have blocks executed events, but did have transaction executed.
The solution is to accumulate the transaction executed events, until you hit the next block executed event.
There was a problem hiding this comment.
Yes, it's handled by the NewEVMEventsAccumulator module
| return nil | ||
| } | ||
|
|
||
| func initStorages(chainID flow.ChainID, dataDir string, executionDataDir string) ( |
There was a problem hiding this comment.
chain ID is not needed
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
2 times, most recently
from
8f6ed3b
to
5db925d
Compare
zhangchiqing
force-pushed
the
leo/add-testcase-for-offchain-evm-backward-compatibilities
branch
from
4fe749e
to
27c0f3a
Compare
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
a725780
to
f564161
Compare
zhangchiqing
force-pushed
the
leo/add-testcase-for-offchain-evm-backward-compatibilities
branch
from
27c0f3a
to
0cfcb7d
Compare
zhangchiqing
requested review from
janezpodhostnik
and removed request for
Kay-Zee
zhangchiqing
force-pushed
the
leo/add-verify-evm-offchain-replay
branch
from
887419e
to
a41e107
Compare
| transactionEvents []events.TransactionEventPayload, | ||
| blockEvent *events.BlockEventPayload, | ||
| ) (types.ReplayResultCollector, error) { | ||
| ) (types.ReplayResultCollector, []*types.Result, error) { |
There was a problem hiding this comment.
Added the result for comparing trie updates, but the original ReplayBlock is unchanged, so that gateway doesn't need to update its usage.
| if chainID == flow.Testnet { | ||
| return flowHeight == 211176670 | ||
| } else if chainID == flow.Mainnet { | ||
| return flowHeight == 85981135 |
There was a problem hiding this comment.
I believe that the proper Flow Height should be 85981134. This is where the EVM contract was first deployed on mainnet, see https://www.flowscan.io/contract/A.e467b9dd11fa00df.EVM/deployments?deployment=85981134
This PR adds a util cmd for verifying the evm offchain replay.
No API change for gateway.