Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS Maintenance Grant: Milestone 1 - Update library to support latest dependencies #206

Closed
wants to merge 35 commits into from

Conversation

MaxStalker
Copy link
Collaborator

Work in progress for #205

Description

  • Bumped packages to latest versions
  • Fixed regular expression used to catch log messages
  • Emulator dependent tests reintroduced to be able to run on CI
  • Updated CI workflows to run latest version of Flow CLI and only on appropriate events
  • Add test coverage report
  • Add dependecy testbed report

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker requested a review from a team as a code owner March 8, 2023 15:49
@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: eb31579

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MaxStalker MaxStalker mentioned this pull request Mar 8, 2023
@MaxStalker MaxStalker self-assigned this Mar 9, 2023
@MaxStalker MaxStalker added the dependencies Pull requests that update a dependency file label Mar 9, 2023
@MaxStalker
Copy link
Collaborator Author

Closing this one if favor of #207 - because public forks can't output code coverage and comments on PR.
Need more investigation on the issue, but it's outside of the scope what this PR tries to fix.

@MaxStalker MaxStalker closed this Mar 10, 2023
@fotescodev
Copy link

@sideninja how can we help @MaxStalker here? Can we add comments on PRs through Github Actions so Max can finish this? @justinbarry FYI

@MaxStalker
Copy link
Collaborator Author

@fotescodev It works if PR was created for a branch on this specific repo. So all maintainers will be able to launch actions properly and with necessary access rights for GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants