Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS Support Grant: Milestone 2 - Add methods to inspect account storage #214

Closed
wants to merge 11 commits into from

Conversation

MaxStalker
Copy link
Collaborator

Work in progress for #205

Description

This PR adds multiple new methods to query storage:

  • getPaths - returning an object containing paths for public, private and storage domains
  • getPathsWithType - same as above, but with more detailed info about Capabilities
  • getStorageValue - returning value at specified storage path
  • getStorageStats - used and storage capacity info

Jest helpers added:

  • shallHavePath - checks that account have path on specified domain
  • shallHaveStorageValue - checks that account have specific value stored

Documentation

Updated documentation:

  • API reference for newly added functions
  • Jest Asserts documentation

Tests

All new methods are covered with tests.

Changeset:

Changeset for new minor version is included

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 7, 2023
@MaxStalker MaxStalker requested a review from a team as a code owner April 7, 2023 21:28
@MaxStalker MaxStalker self-assigned this Apr 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023

🦋 Changeset detected

Latest commit: 1c7cda6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MaxStalker MaxStalker mentioned this pull request Apr 7, 2023
@MaxStalker
Copy link
Collaborator Author

Closed in favor of #215 cause it need to be on this fork in order for scripts to work properly...

@MaxStalker MaxStalker closed this Apr 7, 2023
@MaxStalker MaxStalker added the bug Something isn't working label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant