Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS Support Grant: Milestone 3 - Compatibility Check Workflow #221

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MaxStalker
Copy link
Collaborator

@MaxStalker MaxStalker commented May 26, 2023

Work in progress for #205

Description

This PR add new scheduled workflow to check Flow CLI and JS Testing compatibility.

Workflow Process

  • Install latest version of Flow CLI
  • Grab Flow CLI version, current Flow JS Testing package version and check compatibility.json file to see if this was already tested
  • If compatibility table have the entry for specific versions, skip the rest of the steps
  • Otherwise, run tests via npm test
  • Read the result of jest command into steps outputs
  • If the result is false, create new issue (notice it will check if issue with the same name exist and won't create a duplicate)
  • Update compatibility.json table

Prerequisites

image
Workflow requires a set of permissions in order to create new issues. Required settings are located under:
Settings -> Actions -> General -> Workflow Permissions

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker added the enhancement New feature or request label May 26, 2023
@MaxStalker MaxStalker self-assigned this May 26, 2023
@MaxStalker MaxStalker requested a review from a team as a code owner May 26, 2023 09:45
@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

⚠️ No Changeset found

Latest commit: fd1f09a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant