Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add compatible range to Node Version Info endpoint #1496

Conversation

UlyanaAndrukhiv
Copy link
Contributor

Context

In this PR the openAPI and protobuf spec was updated for NodeVersionInfo endpoint.

@Guitarheroua
Copy link
Contributor

Looks good for me!

I have one small suggestion, maybe the fields start_height and end_height should be named more concretely, like protocol_version_start_height, protocol_version_end_height, or just version_start_height, version_end_height, as it is unclear, especially for REST part, what this data fields responsible for.

@Guitarheroua
Copy link
Contributor

Unfortunately, I cannot approve PRs in this repo. So should wait for @peterargue.

protobuf/flow/entities/node_version_info.proto Outdated Show resolved Hide resolved
openapi/access.yaml Outdated Show resolved Hide resolved
@peterargue peterargue merged commit 1cba659 into onflow:master Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants