-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLIP: FCL Tx Payer Service #612
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onflow/flow-docs/2GCU6ynRrq9udqnVL71sX2nHdZ8h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thorough proposal 👍🏼
very nice proposal, first time seeing FLIP here? what is the etiquette on commenting on FLIPS? Do we comment here? |
Great stuff @JeffreyDoyle ! Most of my comments were abound the non-tech aspects. I want to make sure we make this FLiP extremely clear to ALL parties (PMs, engineers, business people). The beginning part of this we could workshop it a bit to make this really clear. The what and the why here should be super super clear to get interest from outside parties. May be good to get @laynelafrance's eyes on this too from a functional perspective. @laynelafrance can you read this from the POV of 'I am a freelance product person and I am trying to understand why I would do this and the longevity of if I make this into a business.' |
If there will be rate limits, blacklists, and transaction verification, etc will be needed anyway, do you really need the API_KEY there? If we remove API_KEY, this removes the need to have backend communication between Dapp and TPaaS. Also, TPaaS can provide more analytics to Dapp. Also I think some Dapps may want to support something like sponsor transaction costs if the user doesn't already have enough flow to cover the transaction cost (or below some balance threshold).
|
Small spelling changes and comments on how to think about business model/ who would run this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch with spelling improvements and business areas needing clarification
@JeffreyDoyle submitted a few changes. I think you can leave out any additional 'definition of done' things. This should be outlined in the overall FLiP process. Anything specific to this exact project, you already outlined in the FLiP itself. |
@JeffreyDoyle left a new review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall @JeffreyDoyle just some spelling fixes
Applications that wish to guarantee their users can submit transactions | ||
without having to pay transaction fees for them will then have to pay those fees themselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly confusing... how about:
Applications that wish to guarantee their users can submit transactions | |
without having to pay transaction fees for them will then have to pay those fees themselves. | |
Applications that wish to guarantee their users can submit transactions | |
without having to pay transaction fees will have to pay those fees in the users' stead. |
@JeffreyDoyle Is there any movement on this? |
FLIP: FCL Tx Payer Service