Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLIP: FCL Tx Payer Service #612

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

JeffreyDoyle
Copy link
Member

FLIP: FCL Tx Payer Service

@vercel
Copy link

vercel bot commented Aug 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-docs/2GCU6ynRrq9udqnVL71sX2nHdZ8h
✅ Preview: https://flow-docs-git-flip-fcl-tx-payer-service-onflow.vercel.app

Copy link
Contributor

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thorough proposal 👍🏼

@bluesign
Copy link
Contributor

bluesign commented Aug 26, 2021

very nice proposal, first time seeing FLIP here? what is the etiquette on commenting on FLIPS? Do we comment here?

@sifmoon
Copy link
Contributor

sifmoon commented Aug 29, 2021

Great stuff @JeffreyDoyle ! Most of my comments were abound the non-tech aspects. I want to make sure we make this FLiP extremely clear to ALL parties (PMs, engineers, business people). The beginning part of this we could workshop it a bit to make this really clear. The what and the why here should be super super clear to get interest from outside parties.

May be good to get @laynelafrance's eyes on this too from a functional perspective. @laynelafrance can you read this from the POV of 'I am a freelance product person and I am trying to understand why I would do this and the longevity of if I make this into a business.'

@bluesign
Copy link
Contributor

If there will be rate limits, blacklists, and transaction verification, etc will be needed anyway, do you really need the API_KEY there?

If we remove API_KEY, this removes the need to have backend communication between Dapp and TPaaS. Also, TPaaS can provide more analytics to Dapp.

Also I think some Dapps may want to support something like sponsor transaction costs if the user doesn't already have enough flow to cover the transaction cost (or below some balance threshold).

  • In the light of those, wouldn't be beneficial for TPaaS to host an access API? Work as like wallets, replace payer signature if come conditions met ( rate limits, blacklists, transaction verification, flow balance, etc), so by using their access node, you may have access to analytics and transaction payment just by pointing your access API URL to theirs.

  • Or at least if the wallet is sponsoring the transaction fee why should Dapp pay to TPaaS? It can be another service call before sending the transaction, so TPaaS can replace the signature only if necessary. (I think in that case just a new FCL config for TPaaS endpoint should be enough)

Small spelling changes and comments on how to think about business model/ who would run this
Copy link
Member

@laynelafrance laynelafrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch with spelling improvements and business areas needing clarification

flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
@sifmoon
Copy link
Contributor

sifmoon commented Sep 8, 2021

@JeffreyDoyle submitted a few changes. I think you can leave out any additional 'definition of done' things. This should be outlined in the overall FLiP process. Anything specific to this exact project, you already outlined in the FLiP itself.

flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
flips/20210824-fcl-tx-payer-service.md Outdated Show resolved Hide resolved
@sifmoon
Copy link
Contributor

sifmoon commented Sep 9, 2021

@JeffreyDoyle left a new review!

Copy link
Member

@laynelafrance laynelafrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall @JeffreyDoyle just some spelling fixes

Comment on lines +56 to +57
Applications that wish to guarantee their users can submit transactions
without having to pay transaction fees for them will then have to pay those fees themselves.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly confusing... how about:

Suggested change
Applications that wish to guarantee their users can submit transactions
without having to pay transaction fees for them will then have to pay those fees themselves.
Applications that wish to guarantee their users can submit transactions
without having to pay transaction fees will have to pay those fees in the users' stead.

@pgebheim
Copy link
Contributor

@JeffreyDoyle Is there any movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants