Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Create Javascript tests #90

Merged
merged 41 commits into from
Jun 11, 2021
Merged

Create Javascript tests #90

merged 41 commits into from
Jun 11, 2021

Conversation

MaxStalker
Copy link
Contributor

@MaxStalker MaxStalker commented May 19, 2021

Use Jest and Testing Framework to create test suits written in Javascript:

  • Tests for Kibble contract
  • Tests for KittyItems contract
  • Tests for KittyItemsMarket contract

@MaxStalker MaxStalker requested a review from 10thfloor May 19, 2021 10:51
@MaxStalker MaxStalker self-assigned this May 19, 2021
Copy link
Contributor

@10thfloor 10thfloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@10thfloor
Copy link
Contributor

10thfloor commented May 19, 2021

This looks great @MaxStalker, should we add some documentation about the testing framework, or provide a link in the README instructions to the testing repo / docs so folks have some context?

@MaxStalker
Copy link
Contributor Author

Great idea, @10thfloor !
This should greatly benefit both repos. Will add it right away!

@MaxStalker
Copy link
Contributor Author

Please, wait with merging @10thfloor - we need to release new version of js-testing-framework and updated package.json with proper version instead of local path.

@10thfloor 10thfloor changed the title Create Javasript tests Create Javascript tests May 26, 2021
@10thfloor
Copy link
Contributor

@MaxStalker Ready to merge?

cadence/lib/js/README.md Outdated Show resolved Hide resolved
cadence/lib/js/flow.json Show resolved Hide resolved
cadence/lib/js/src/common.js Outdated Show resolved Hide resolved
cadence/lib/js/src/kibble.js Outdated Show resolved Hide resolved
cadence/lib/js/src/kibble.js Outdated Show resolved Hide resolved
cadence/lib/js/src/kibble.js Outdated Show resolved Hide resolved
cadence/lib/js/src/kitty-items-marketplace.js Outdated Show resolved Hide resolved
cadence/lib/js/src/kitty-items-marketplace.js Outdated Show resolved Hide resolved
cadence/lib/js/test/kibble.test.js Outdated Show resolved Hide resolved
cadence/lib/js/test/kibble.test.js Show resolved Hide resolved
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@MaxStalker MaxStalker merged commit 7ac8189 into master Jun 11, 2021
@MaxStalker MaxStalker deleted the max/js-test-for-kitti-items branch June 11, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants