Improve performance

ongakuer · Jul 31, 2019 · bf5fff8 · bf5fff8
1 parent 69254cb
commit bf5fff8
Show file tree

Hide file tree

Showing 4 changed files with 56 additions and 35 deletions.
diff --git a/circleindicator/src/main/java/me/relex/circleindicator/BaseCircleIndicator.java b/circleindicator/src/main/java/me/relex/circleindicator/BaseCircleIndicator.java
@@ -12,7 +12,6 @@
 import android.view.View;
 import android.view.animation.Interpolator;
 import android.widget.LinearLayout;
-import androidx.annotation.DrawableRes;
 import androidx.annotation.Nullable;
 
 class BaseCircleIndicator extends LinearLayout {
@@ -148,46 +147,65 @@ protected Animator createAnimatorIn(Config config) {
     }
 
     public void createIndicators(int count, int currentPosition) {
-        int orientation = getOrientation();
+        if (mImmediateAnimatorOut.isRunning()) {
+            mImmediateAnimatorOut.end();
+            mImmediateAnimatorOut.cancel();
+        }
+
+        if (mImmediateAnimatorIn.isRunning()) {
+            mImmediateAnimatorIn.end();
+            mImmediateAnimatorIn.cancel();
+        }
+
+        // Diff View
+        int childViewCount = getChildCount();
+        if (count < childViewCount) {
+            removeViews(count, childViewCount - count);
+        } else if (count > childViewCount) {
+            int addCount = count - childViewCount;
+            int orientation = getOrientation();
+            for (int i = 0; i < addCount; i++) {
+                addIndicator(orientation);
+            }
+        }
+
+        // Bind Style
         View indicator;
         for (int i = 0; i < count; i++) {
+            indicator = getChildAt(i);
             if (currentPosition == i) {
-                indicator =
-                        addIndicator(orientation, mIndicatorBackgroundResId, mImmediateAnimatorOut);
+                indicator.setBackgroundResource(mIndicatorBackgroundResId);
+                mImmediateAnimatorOut.setTarget(indicator);
+                mImmediateAnimatorOut.start();
+                mImmediateAnimatorOut.end();
             } else {
-                indicator = addIndicator(orientation, mIndicatorUnselectedBackgroundResId,
-                        mImmediateAnimatorIn);
+                indicator.setBackgroundResource(mIndicatorUnselectedBackgroundResId);
+                mImmediateAnimatorIn.setTarget(indicator);
+                mImmediateAnimatorIn.start();
+                mImmediateAnimatorIn.end();
             }
+
             if (mIndicatorCreatedListener != null) {
                 mIndicatorCreatedListener.onIndicatorCreated(indicator, i);
             }
         }
+
+        mLastPosition = currentPosition;
     }
 
-    protected View addIndicator(int orientation, @DrawableRes int backgroundDrawableId,
-            Animator animator) {
-        if (animator.isRunning()) {
-            animator.end();
-            animator.cancel();
-        }
+    protected void addIndicator(int orientation) {
         View indicator = new View(getContext());
-        indicator.setBackgroundResource(backgroundDrawableId);
-        addView(indicator, mIndicatorWidth, mIndicatorHeight);
-        LayoutParams lp = (LayoutParams) indicator.getLayoutParams();
-
+        final LayoutParams params = generateDefaultLayoutParams();
+        params.width = mIndicatorWidth;
+        params.height = mIndicatorHeight;
         if (orientation == HORIZONTAL) {
-            lp.leftMargin = mIndicatorMargin;
-            lp.rightMargin = mIndicatorMargin;
+            params.leftMargin = mIndicatorMargin;
+            params.rightMargin = mIndicatorMargin;
         } else {
-            lp.topMargin = mIndicatorMargin;
-            lp.bottomMargin = mIndicatorMargin;
+            params.topMargin = mIndicatorMargin;
+            params.bottomMargin = mIndicatorMargin;
         }
-
-        indicator.setLayoutParams(lp);
-        animator.setTarget(indicator);
-        animator.start();
-
-        return indicator;
+        addView(indicator, params);
     }
 
     public void animatePageSelected(int position) {

diff --git a/circleindicator/src/main/java/me/relex/circleindicator/CircleIndicator.java b/circleindicator/src/main/java/me/relex/circleindicator/CircleIndicator.java
@@ -45,11 +45,12 @@ public void setViewPager(@Nullable ViewPager viewPager) {
     }
 
     private void createIndicators() {
-        removeAllViews();
         PagerAdapter adapter = mViewpager.getAdapter();
         int count;
-        if (adapter == null || (count = adapter.getCount()) <= 0) {
-            return;
+        if (adapter == null) {
+            count = 0;
+        } else {
+            count = adapter.getCount();
         }
         createIndicators(count, mViewpager.getCurrentItem());
     }

diff --git a/circleindicator/src/main/java/me/relex/circleindicator/CircleIndicator2.java b/circleindicator/src/main/java/me/relex/circleindicator/CircleIndicator2.java
@@ -47,11 +47,12 @@ public void attachToRecyclerView(@NonNull RecyclerView recyclerView,
     }
 
     private void createIndicators() {
-        removeAllViews();
         RecyclerView.Adapter adapter = mRecyclerView.getAdapter();
         int count;
-        if (adapter == null || (count = adapter.getItemCount()) <= 0) {
-            return;
+        if (adapter == null) {
+            count = 0;
+        } else {
+            count = adapter.getItemCount();
         }
         createIndicators(count, getSnapPosition(mRecyclerView.getLayoutManager()));
     }

diff --git a/circleindicator/src/main/java/me/relex/circleindicator/CircleIndicator3.java b/circleindicator/src/main/java/me/relex/circleindicator/CircleIndicator3.java
@@ -45,11 +45,12 @@ public void setViewPager(@Nullable ViewPager2 viewPager) {
     }
 
     private void createIndicators() {
-        removeAllViews();
         RecyclerView.Adapter adapter = mViewpager.getAdapter();
         int count;
-        if (adapter == null || (count = adapter.getItemCount()) <= 0) {
-            return;
+        if (adapter == null) {
+            count = 0;
+        } else {
+            count = adapter.getItemCount();
         }
         createIndicators(count, mViewpager.getCurrentItem());
     }