Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SnapHelpers that display multiple items after a snap event #144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for SnapHelpers that display multiple items after a snap event #144

wants to merge 2 commits into from

Commits on Jul 23, 2020

  1. Create SnapIndexController interface to abstract out SnapHelper and i… 

    …ndicator index and item count relationship. This way we can use CircleIndicator2 with SnapHelpers that supports more than one item on a single webpage such as SnapToBlock. (https://stackoverflow.com/a/47580753/6644987)

- Create SnapIndexController interface
- Delegate all calls that related to indicator index and indicator count to SnapIndexController in CircleIndicator2 class.
- Create SimpleSnapIndexController class for SnapHelpers that shows a single item on a single page.
- Add an overloading attachToRecyclerView method to CircleIndicator2
    @MertNYuksel
    MertNYuksel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7b349f8 View commit details
    Browse the repository at this point in the history

  2. Make SnapIndexController public

    @MertNYuksel
    MertNYuksel committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    2a2e973 View commit details
    Browse the repository at this point in the history