Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): Customizable title bar style #3765

Merged
merged 8 commits into from
Jul 22, 2021

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jul 14, 2021

Issue: There are several quirks on Windows with the 'undecorated' Windows style - issues like:

Fix: These can be deal-breakers for use as a daily editor, so until we have those fixed for the 'undecorated' Windows, change the default setting to use the native titlebar.

This introduces a new setting - window.titleBarStyle that can be "native" or "custom". The "custom" titlebar looks nicer, because it is themed and custom rendered, however it has the above quirks. On Windows, change the default to "native".

In addition, this pushes up the configuration loading sooner in the startup cycle, so we can pick up configuration settings like "window.titleBarStyle" prior to opening the window.

Todo:

  • Fix margin on Windows, based on whether we are using the decorated window or not
  • Test OSX
  • Test Windows (both settings)
  • Test on Linux (both settings)

@bryphe bryphe merged commit 0cd8c42 into master Jul 22, 2021
@bryphe bryphe deleted the feat/windows/title-bar-style branch July 22, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant