feat(windows): Customizable title bar style #3765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: There are several quirks on Windows with the 'undecorated' Windows style - issues like:
Fix: These can be deal-breakers for use as a daily editor, so until we have those fixed for the 'undecorated' Windows, change the default setting to use the native titlebar.
This introduces a new setting -
window.titleBarStyle
that can be"native"
or"custom"
. The"custom"
titlebar looks nicer, because it is themed and custom rendered, however it has the above quirks. On Windows, change the default to"native"
.In addition, this pushes up the configuration loading sooner in the startup cycle, so we can pick up configuration settings like
"window.titleBarStyle"
prior to opening the window.Todo: