Space and Time Reduction #60
Conversation
matthewjmarangoni
force-pushed
the
upd-space-and-time
branch
from
94603a7 to
18ae79c
Compare
There was a problem hiding this comment.
one question otherwise looks awesome. Thanks @matthewjmarangoni!
|
Caching can be used to help builds continue to run if a resource is offline and having just experienced an outage of the Also cleaned up a straggler that was removing index metadata. |
matthewjmarangoni
force-pushed
the
upd-space-and-time
branch
2 times, most recently
from
1e8213e to
d66de84
Compare
|
Changing the locking mechanism for apt caches supports multiple writers and yields some time reduction. |
Cache packages, remove unused packages, and prevent installation of apt recommended packages.
matthewjmarangoni
force-pushed
the
upd-space-and-time
branch
from
d4a4831 to
0a438f7
Compare
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 330685e...0a438f7
6 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
matthewjmarangoni
force-pushed
the
upd-space-and-time
branch
from
d91a31b to
2d40710
Compare
There was a problem hiding this comment.
Performed full review of 330685e...2d40710
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
6 files reviewed | 6 comments | Review on Mesa | Edit Reviewer Settings
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@matthewjmarangoni let me know when you want another review! Would like to get this one over the finish line |
There was a problem hiding this comment.
Performed full review of 330685e...992f8fd
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
6 files reviewed | 6 comments | Review on Mesa | Edit Reviewer Settings
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
@rgarcia as long as that answer for the previous question you had was sufficient, it should be ready now that other issues have been resolved! |
There was a problem hiding this comment.
Performed full review of 330685e...992f8fd
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
6 files reviewed | 7 comments | Review on Mesa | Edit Reviewer Settings
2 participants
This is a pass to reduce build times and image sizes. The impact varies but the general expectation is improvement.
Image size reductions of 18% - 30% and build time reductions of 7% - 35% were found. Some results were greater yet less consistent and should not be expected.
Changes to achieve this include:
apt,npm,go, staticffmpegbuildsaptconfiguration changed to prevent automatic cache removal and to preserve downloadsaptpackages are no longer installedManual testing was done. Further testing is requested to verify impact and functionality. Particularly of interest are differing and constrained environments such as CI/CD pipelines.
TL;DR
Reduced Docker image sizes and build times by implementing widespread caching for
apt,npm,go, andffmpegbuilds.Why we made these changes
To reduce build times and image sizes for faster, more efficient CI/CD pipelines and local development. Image size reductions of 18% - 30% and build time reductions of 7% - 35% were observed in testing.
What changed?
--mount=type=cache) across multiple Dockerfiles to cache dependencies forapt,npm,go, and staticffmpegbuilds.aptUsage: Configuredaptto retain its cache and consistently used the--no-install-recommendsflag to prevent installing unnecessary packages, minimizing image size.gpg-agentto ensure build reliability..mise.tomlto.gitignore.Validation
Manual testing was done. Further testing is requested to verify impact and functionality, particularly in differing and constrained environments such as CI/CD pipelines.
Description generated by Mesa. Update settings