Add devcontainer configuration for development #65
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "name": "Kernel Devcontainer", | ||
| "image": "mcr.microsoft.com/devcontainers/base:ubuntu", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/go:1": {}, | ||
| "ghcr.io/devcontainers/features/node:1": { | ||
| "nodeGypDependencies": false, | ||
| "version": "latest" | ||
| } | ||
| }, | ||
| "onCreateCommand": "sudo apt-get -y update && sudo apt-get -y install ca-certificates curl gnupg lsb-release && sudo mkdir -p /etc/apt/keyrings && curl -fsSL https://deb.pkg.kraftkit.sh/gpg.key | sudo gpg --dearmor -o /etc/apt/keyrings/unikraft.gpg && echo \"deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/unikraft.gpg] https://deb.pkg.kraftkit.sh /\" | sudo tee /etc/apt/sources.list.d/unikraft.list >/dev/null && sudo apt-get -y update && sudo apt-get -y install kraftkit && sudo apt-get -y upgrade", | ||
|
There was a problem hiding this comment.
The onCreateCommand downloads and installs kraftkit from an external source without checksum verification. Consider verifying the GPG key fingerprint and using a specific version of kraftkit to ensure reproducible and secure builds. The current approach trusts the GPG key from the URL without verification. |
||
| "forwardPorts": [ | ||
| 444, | ||
| 8080, | ||
| 9222 | ||
| ], | ||
| "portsAttributes": { | ||
| "444": { | ||
| "label": "Kernel Images API", | ||
| "onAutoForward": "notify" | ||
| }, | ||
| "8080": { | ||
| "label": "Web Interface (Neko WebRTC UI)", | ||
| "onAutoForward": "notify" | ||
| }, | ||
| "9222": { | ||
| "label": "CDP (ncat Chromium)", | ||
| "onAutoForward": "notify" | ||
| } | ||
| }, | ||
| // WebRTC UDP ports | ||
| "appPort": [ | ||
| "56000-56100:56000-56100/udp" | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using "latest" for Node.js version can lead to inconsistent development environments across team members and over time. Consider pinning to a specific version or LTS version for reproducible builds.
Agent: 🤖 General