Skip to content

95 updates to installation #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

kulbachcedric
Copy link
Collaborator

Hi @atanikan,
I changed and fixed the issues you mentioned in #95.
Would that changes go into the direction you'd expect?

Best
Cedric

@kulbachcedric kulbachcedric linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (f07d3c0) to head (e78e7e5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
deep_river/classification/rolling_classifier.py 16.66% 5 Missing ⚠️
deep_river/classification/classifier.py 20.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files          26       26           
  Lines        1254     1254           
=======================================
  Hits         1001     1001           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulbachcedric kulbachcedric merged commit 32d2f3c into master Nov 18, 2024
6 checks passed
@kulbachcedric kulbachcedric deleted the 95-updates-to-installation branch November 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to installation
2 participants