Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asyncio.wait call for python 3.11 #73

Merged
merged 12 commits into from
Aug 11, 2023
Merged

Conversation

marcus29200
Copy link
Contributor

@marcus29200 marcus29200 commented Aug 10, 2023

Updating to python 3.11 causes an error on this line, specifically Passing coroutines is forbidden, use tasks explicitly. Converting these to tasks before running them solves the issue.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #73 (9a9fe49) into master (bf3e04d) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          10       10           
  Lines        1018     1018           
=======================================
  Hits          983      983           
  Misses         35       35           
Files Changed Coverage Δ
kafkaesk/app.py 97.41% <ø> (ø)
kafkaesk/consumer.py 91.85% <ø> (ø)
kafkaesk/ext/logging/handler.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marcus29200 marcus29200 force-pushed the python3-11-updates branch 2 times, most recently from 6e4ea40 to dd7a204 Compare August 10, 2023 21:41
@marcus29200 marcus29200 deleted the python3-11-updates branch August 10, 2023 21:43
@marcus29200 marcus29200 restored the python3-11-updates branch August 10, 2023 21:44
@marcus29200 marcus29200 reopened this Aug 10, 2023
@marcus29200 marcus29200 merged commit c0c6df3 into master Aug 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants