Skip to content

Conversation

justinchuby
Copy link
Member

When the attribute is string, for example, we want to display "attr" instead of attr.

When the attribute is string, for example, we want to display `"attr"` instead of `attr`.

Signed-off-by: Justin Chu <[email protected]>
@justinchuby justinchuby requested review from titaiwangms and a team as code owners September 12, 2025 14:33
@justinchuby justinchuby added this to the 0.1.9 milestone Sep 12, 2025
@justinchuby justinchuby enabled auto-merge (squash) September 12, 2025 14:33
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.71%. Comparing base (745f68a) to head (fbf0ed6).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onnx_ir/_core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files          40       40           
  Lines        4896     4896           
  Branches      974      974           
=======================================
  Hits         3756     3756           
  Misses        855      855           
  Partials      285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby merged commit edee33f into main Sep 12, 2025
23 checks passed
@justinchuby justinchuby deleted the justinchu/attr-str branch September 12, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants