-
Notifications
You must be signed in to change notification settings - Fork 13
Implement shape merging in identity elimination pass #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Following microsoft/onnxscript#2588. Handle shape info as well. Signed-off-by: Justin Chu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements shape merging functionality in the identity elimination pass to preserve shape information when eliminating redundant Identity nodes. The change builds on previous work to handle shape metadata during optimization.
- Adds a
_merge_shapes
helper function to intelligently combine shape information from input and output values - Updates the identity elimination logic to preserve the most complete shape and type information available
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 76.80% 76.58% -0.23%
==========================================
Files 40 40
Lines 4915 4936 +21
Branches 978 986 +8
==========================================
+ Hits 3775 3780 +5
- Misses 856 867 +11
- Partials 284 289 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <[email protected]> Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
This PR implements shape merging functionality in the identity elimination pass to preserve shape information when eliminating redundant Identity nodes.
Following microsoft/onnxscript#2588.