Skip to content

Avoid override new_value info with None from old_value #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2025
Merged

Avoid override new_value info with None from old_value #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/onnx_ir/_convenience/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,12 +397,15 @@ def replace_nodes_and_values(
"""
for old_value, new_value in zip(old_values, new_values):
# Propagate relevant info from old value to new value
# TODO(Rama): Perhaps this should be a separate utility function. Also, consider
# merging old and new type/shape info.
new_value.type = old_value.type
new_value.shape = old_value.shape
new_value.const_value = old_value.const_value
new_value.name = old_value.name
# TODO(Rama): Perhaps this should be a separate utility function.
new_value.type = old_value.type if old_value.type is not None else new_value.type
new_value.shape = old_value.shape if old_value.shape is not None else new_value.shape
new_value.const_value = (
old_value.const_value
if old_value.const_value is not None
else new_value.const_value
)
new_value.name = old_value.name if old_value.name is not None else new_value.name

# Reconnect the users of the deleted values to use the new values
replace_all_uses_with(old_values, new_values)
Expand Down