-
Notifications
You must be signed in to change notification settings - Fork 374
Fix some bugs in onnxmlirtorch package #3319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bb991fb
Fix some bugs in onnxmlirtorch package
tungld cd1b1f3
Merge branch 'main' into onnxmlirtorch-some-bugs
tungld 1cce5f0
Use a global sessioncache to fix the issue of recompilation
tungld f0e8687
blalck format
tungld 282c221
Merge branch 'main' into onnxmlirtorch-some-bugs
tungld 9374f4d
Merge branch 'main' into onnxmlirtorch-some-bugs
tungld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,7 @@ class InferenceSession: | |
| def __init__(self, model_path, **kwargs): | ||
| self.debug = False | ||
| self.session = None | ||
| self.output_dir = tempfile.TemporaryDirectory() | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to keep this temp folder, so move it to the class member. Otherwise, the temp folder is cleaned up automatically. |
||
| self.handleParameters(model_path, **kwargs) | ||
| if self.session is not None: | ||
| return | ||
|
|
@@ -117,7 +118,7 @@ def handleParameters(self, model_path, **kwargs): | |
| self.compiled_model += ".so" | ||
| self.output_dirname = os.path.dirname(self.compiled_model) | ||
| else: | ||
| self.output_dirname = tempfile.TemporaryDirectory().name | ||
| self.output_dirname = self.output_dir.name | ||
| self.compiled_model = os.path.join( | ||
| self.output_dirname, self.model_basename.removesuffix(self.model_suffix) | ||
| ) | ||
|
|
@@ -292,7 +293,7 @@ def Compile(self): | |
|
|
||
| def getSession(self): | ||
| # When the script is used in package onnxmlir, the files to be imported | ||
| # are within the package. Path in the pakcage should be used. | ||
| # are within the package. Path in the package should be used. | ||
| # Otherwise, env variable ONNX_MLIR_HOME is used to for import path | ||
| if __package__ == "onnxmlir" or __package__ == "onnxmlirtorch": | ||
| try: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing
libsfolder so that OMExecutionSession was not found.