-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare to release v1.0.0 #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
jeremyfowers
force-pushed
the
57-release-notes-markdown-file
branch
from
December 5, 2023 20:45
db85292
to
d990a54
Compare
Release candidate available for testing: https://test.pypi.org/project/turnkeyml/1.0.0/ |
Signed-off-by: Jeremy Fowers <[email protected]>
jeremyfowers
commented
Dec 5, 2023
jeremyfowers
commented
Dec 5, 2023
danielholanda
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Jeremy Fowers <[email protected]>
Signed-off-by: Jeremy Fowers <[email protected]>
jeremyfowers
added a commit
that referenced
this pull request
Dec 6, 2023
* Add v1.0.0 release notes * Add public API contract * Rev version number to v1.0.0 * Move logged_subprocess() from build to plugin_helers --------- Signed-off-by: Jeremy Fowers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
logged_subprocess()
function from thecommon.build
module torun.plugin_helpers
, since it is never used during build and is only used during runtime plugins.