Skip to content

add To/ToNot/NotTo aliases for AsyncAssertion#838

Merged
onsi merged 1 commit intoonsi:masterfrom
grosser:grosser/to
Apr 2, 2025
Merged

add To/ToNot/NotTo aliases for AsyncAssertion#838
onsi merged 1 commit intoonsi:masterfrom
grosser:grosser/to

Conversation

@grosser
Copy link
Copy Markdown
Contributor

@grosser grosser commented Apr 2, 2025

fixes fixes #837

go mod edit -replace=github.com/onsi/gomega=github.com/grosser/gomega@grosser/to
Eventually(func() bool {
	err := getObj(hpa)
	return err == nil && hpa.Spec.MaxReplicas == expectedReplicas
}, "1s", "10ms").To(BeTrue())

even better would be ExpectEventually ... To BeTrue, but 🤷

@onsi onsi merged commit 5666f98 into onsi:master Apr 2, 2025
6 checks passed
@onsi
Copy link
Copy Markdown
Owner

onsi commented Apr 2, 2025

even better would be ExpectEventually ... To BeTrue, but 🤷

or even Expect(foo).ToEventuallyBe(True()) but... 🤷 indeed.

@onsi
Copy link
Copy Markdown
Owner

onsi commented Apr 2, 2025

i've pulled this in and will cut a release so you can play with it.

@onsi
Copy link
Copy Markdown
Owner

onsi commented Apr 2, 2025

out now in 1.37.0

@grosser
Copy link
Copy Markdown
Contributor Author

grosser commented Apr 2, 2025

Expect(foo).To EventuallyBe(True()) ? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eventually / gomega.AsyncAssertion "has no field or method To"

2 participants