Skip to content

fix: Section layout component fix #7305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunakab merged 1 commit into from
Jan 9, 2026
Merged

fix: Section layout component fix #7305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/refresh-components/cards/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default function Card({

return (
<div className={cn("rounded-16 w-full h-full", classNames[variant])}>
<GeneralLayouts.Section padding={padding} {...props} />
<GeneralLayouts.Section alignItems="start" padding={padding} {...props} />
Copy link
Contributor

@greptile-apps greptile-apps bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignItems="start" prop is placed before {...props}, which means any alignItems value passed through props will override it. Since CardProps extends GeneralLayouts.SectionProps, users can pass alignItems and it will defeat this fix. Move alignItems="start" after {...props} to ensure it cannot be overridden:

Suggested change
<GeneralLayouts.Section alignItems="start" padding={padding} {...props} />
<GeneralLayouts.Section padding={padding} {...props} alignItems="start" />

</div>
);
}
Loading