Skip to content

feat: Modal updates #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunakab merged 20 commits into from
Jan 10, 2026
Merged

feat: Modal updates #7306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6766249
Remove classNames from modal footers
raunakab Jan 9, 2026
3d6a902
Remove classNames from modal content
raunakab Jan 9, 2026
6944785
Remove classNames from modal header
raunakab Jan 9, 2026
cdb405a
Remove unnecessary `twoTone` flag invocation
raunakab Jan 9, 2026
d8c3402
Update modal body styling
raunakab Jan 9, 2026
380871b
More updates
raunakab Jan 9, 2026
a89c8b1
Fix spacing for footer components
raunakab Jan 9, 2026
2fa3601
Update docs
raunakab Jan 9, 2026
764924f
Fix some dumb className overrides of the IconButton
raunakab Jan 9, 2026
5da3e84
Merge branch 'main' into pr5a-modal-updates
raunakab Jan 9, 2026
0eefeae
Fix more modals
raunakab Jan 9, 2026
ed59a93
Fix more modals
raunakab Jan 10, 2026
57af2ae
Delete unused files
raunakab Jan 10, 2026
ff87396
Revert some old changes
raunakab Jan 10, 2026
3b794cb
Render description conditionally
raunakab Jan 10, 2026
0eec13a
Remove fragment wrapper
raunakab Jan 10, 2026
073cda4
Saving changes
raunakab Jan 10, 2026
8510270
Fix error in react hooks
raunakab Jan 10, 2026
e66cae7
Add back scroll shadow
raunakab Jan 10, 2026
8a82875
Add json parsing validation
raunakab Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions web/src/app/admin/configuration/llm/forms/components/FormWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,7 @@ export function ProviderFormEntrypointWrapper({
title={`Setup ${providerName}`}
onClose={onClose}
/>
<Modal.Body className="max-h-[70vh] overflow-y-auto">
{children(context)}
</Modal.Body>
<Modal.Body>{children(context)}</Modal.Body>
</Modal.Content>
</Modal>
)}
Expand Down Expand Up @@ -208,9 +206,7 @@ export function ProviderFormEntrypointWrapper({
}`}
onClose={onClose}
/>
<Modal.Body className="max-h-[70vh] overflow-y-auto">
{children(context)}
</Modal.Body>
<Modal.Body>{children(context)}</Modal.Body>
</Modal.Content>
</Modal>
)}
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/configuration/search/UpgradingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default function UpgradingPage({
previous model and all progress will be lost.
</div>
</Modal.Body>
<Modal.Footer className="p-4 flex gap-x-2 w-full justify-end">
<Modal.Footer>
<Button onClick={onCancel}>Confirm</Button>
<Button onClick={() => setIsCancelling(false)} secondary>
Cancel
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/configuration/web-search/WebProviderSetupModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export const WebProviderSetupModal = memo(
</FormField>
)}
</Modal.Body>
<Modal.Footer className="gap-2">
<Modal.Footer>
<Button type="button" main secondary onClick={onClose}>
Cancel
</Button>
Expand Down
2 changes: 0 additions & 2 deletions web/src/app/admin/configuration/web-search/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,6 @@ export default function Page() {
provider
);
}}
className="h-6 w-6 opacity-70 hover:opacity-100"
aria-label={`Edit ${label}`}
/>
)}
Expand Down Expand Up @@ -1134,7 +1133,6 @@ export default function Page() {
provider
);
}}
className="h-6 w-6 opacity-70 hover:opacity-100"
aria-label={`Edit ${label}`}
/>
)}
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/connector/[ccPairId]/IndexAttemptErrorsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export default function IndexAttemptErrorsModal({
}
onClose={onClose}
/>
<Modal.Body className="flex flex-col gap-4 min-h-0">
<Modal.Body>
{!isResolvingErrors && (
<div className="flex flex-col gap-2 flex-shrink-0">
<Text as="p">
Expand Down
8 changes: 4 additions & 4 deletions web/src/app/admin/connector/[ccPairId]/InlineFileManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ interface InlineFileManagementProps {
onRefresh: () => void;
}

export function InlineFileManagement({
export default function InlineFileManagement({
connectorId,
onRefresh,
}: InlineFileManagementProps) {
Expand Down Expand Up @@ -360,7 +360,7 @@ export function InlineFileManagement({
description="When you save these changes, the following will happen:"
/>

<Modal.Body className="px-6 space-y-3">
<Modal.Body>
{selectedFilesToRemove.size > 0 && (
<div className="p-3 bg-red-50 dark:bg-red-900/10 rounded-md">
<Text
Expand Down Expand Up @@ -402,15 +402,15 @@ export function InlineFileManagement({
)}
</Modal.Body>

<Modal.Footer className="p-6 pt-4">
<Modal.Footer>
<Button
onClick={() => setShowSaveConfirm(false)}
secondary
disabled={isSaving}
>
Cancel
</Button>
<Button onClick={handleConfirmSave} primary disabled={isSaving}>
<Button onClick={handleConfirmSave} disabled={isSaving}>
{isSaving ? "Saving..." : "Confirm & Save"}
</Button>
</Modal.Footer>
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/connector/[ccPairId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
} from "./ConfigDisplay";
import DeletionErrorStatus from "./DeletionErrorStatus";
import { IndexAttemptsTable } from "./IndexAttemptsTable";
import { InlineFileManagement } from "./InlineFileManagement";
import InlineFileManagement from "./InlineFileManagement";
import { buildCCPairInfoUrl, triggerIndexing } from "./lib";
import { Alert, AlertDescription, AlertTitle } from "@/components/ui/alert";
import {
Expand Down
6 changes: 3 additions & 3 deletions web/src/app/admin/embeddings/RerankingFormPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ const RerankingDetailsForm = forwardRef<
better performance.
</p>
</Modal.Body>
<Modal.Footer className="p-4 flex justify-end">
<Modal.Footer>
<Button
onClick={() => setShowGpuWarningModalModel(null)}
>
Expand Down Expand Up @@ -433,7 +433,7 @@ const RerankingDetailsForm = forwardRef<
/>
</div>
</Modal.Body>
<Modal.Footer className="p-4 flex w-full justify-end">
<Modal.Footer>
<Button
onClick={() => {
setShowLiteLLMConfigurationModal(false);
Expand Down Expand Up @@ -513,7 +513,7 @@ const RerankingDetailsForm = forwardRef<
/>
</div>
</Modal.Body>
<Modal.Footer className="p-4 flex w-full justify-end">
<Modal.Footer>
<Button onClick={() => setIsApiKeyModalOpen(false)}>
Update
</Button>
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/embeddings/modals/InstantSwitchConfirmModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function InstantSwitchConfirmModal({
<strong>This is not reversible.</strong>
</Text>
</Modal.Body>
<Modal.Footer className="p-4 gap-2">
<Modal.Footer>
<Button onClick={onConfirm}>Confirm</Button>
<Button secondary onClick={onClose}>
Cancel
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/embeddings/modals/ModelSelectionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export default function ModelSelectionConfirmationModal({
</Callout>
)}
</Modal.Body>
<Modal.Footer className="p-4 gap-2 justify-end">
<Modal.Footer>
<Button onClick={onConfirm}>Confirm</Button>
<Button secondary onClick={onCancel}>
Cancel
Expand Down
2 changes: 1 addition & 1 deletion web/src/app/admin/embeddings/modals/SelectModelModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export default function SelectModelModal({
you will need to undergo a complete re-indexing. Are you sure?
</Text>
</Modal.Body>
<Modal.Footer className="p-4 gap-2 justify-end">
<Modal.Footer>
<Button onClick={onConfirm}>Confirm</Button>
<Button secondary onClick={onCancel}>
Cancel
Expand Down
Loading
Loading